[FIX] Fix issue 973 : in case incoming picking are split, cost calculation is wrong#974
Open
cvinh wants to merge 1 commit intoodoomrp:8.0from
Open
[FIX] Fix issue 973 : in case incoming picking are split, cost calculation is wrong#974cvinh wants to merge 1 commit intoodoomrp:8.0from
cvinh wants to merge 1 commit intoodoomrp:8.0from
Conversation
Member
|
You need to rebase the PR to get only the relevant commit. For the patch itself, we should rework it a little bit more:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in purchase_landed_cost, read_group function has to be "grouped by cost"