fix(ui): mask passphrase entry like every other secret field - #146
Closed
subinita01 wants to merge 2 commits into
Closed
fix(ui): mask passphrase entry like every other secret field#146subinita01 wants to merge 2 commits into
subinita01 wants to merge 2 commits into
Conversation
Owner
|
There's no point on keeping a confirmation dialog that confirms nothing. |
subinita01
force-pushed
the
fix/mask-passphrase-input
branch
from
August 20, 2026 01:54
5705ff0 to
9033f0b
Compare
Contributor
Author
|
@odudex , Is this the right approach?Please check! |
The BIP39 passphrase field was the only secret entry in the app shown in plaintext, with no way to hide it, and the confirmation dialog echoed it back verbatim. PIN and KEF-key entry already mask by default with an eye toggle to reveal on demand; give the passphrase field the same treatment and drop the plaintext echo from the confirm prompt.
A masked "Confirm passphrase?" dialog confirmed nothing: the user can't compare it to anything, so it was just an extra tap. Show the fingerprint transition instead (current > with-passphrase) -- a wrong character still looks like plausible dots either way, but it derives a different wallet, which a mismatched fingerprint makes visible without ever putting the secret on screen. Adds key_mnemonic_passphrase_fingerprint_hex() to core/key, generalizing the existing no-passphrase-only helper. Wallet Settings showed this same base > passphrase fingerprint pair in its nav bar after the change was applied; now that the transition is confirmed up front, that display is redundant. Simplified it to show the single currently-active fingerprint instead.
Owner
|
Thank you! The commits from this PR were rebased and squashed into one. Fingerprint icons were also added the confirmation prompt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
./scripts/format.sh --checkpasses./scripts/test.shpasses (all suites)