fix(pin): check final attempt before wiping - #149
Merged
Conversation
Compare the entered PIN before applying the wipe threshold so a correct PIN on the final allowed attempt still unlocks. Fail closed for corrupted threshold values and add host regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uint8_tthresholdCloses #148
Security behavior
The failure counter is still pre-incremented and committed before PBKDF2, preserving the existing power-cut-safe accounting. Salt/PBKDF2 and stored-hash failures retain their existing fail-closed threshold behavior.
Test plan
make -C main/core/test -B test_pin_attempt && ./main/core/test/test_pin_attempt./scripts/test.sh./scripts/format.sh --checkwave_43firmware buildgit diff --checkScope
This PR intentionally does not change the pre-existing NVS read/write/commit error policy; it is limited to the final-attempt ordering bug and corrupted threshold handling.