Allow aspectRatio to be passed as a float#87
Open
CheeseSucker wants to merge 1 commit intoodyniec:masterfrom
Open
Allow aspectRatio to be passed as a float#87CheeseSucker wants to merge 1 commit intoodyniec:masterfrom
CheeseSucker wants to merge 1 commit intoodyniec:masterfrom
Conversation
Currently aspect ratio must be supplied as two numbers separated by a colon. E.g.
options = {
aspectRatio: "4:3"
}
However, many times it is useful to provide the aspect ratio as a single number. Especially if the aspect ratio is calculated by code.
This patch allows configurations such as:
options = {
aspectRatio: 1.5
}
W1zzardTPU
approved these changes
Feb 20, 2017
|
I agree that this would be useful. Since I already calculate the aspect ratio in my code, I hacked my version of the plugin to only take a float, but supporting both possibilities (string or float) is probably best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, aspect ratio must be supplied as two numbers separated by a colon.
However, it is often useful to provide the aspect ratio as a single number.
Especially if the aspect ratio is calculated by code.
This patch allows configurations such as: