Skip to content

test(memory): cover owner isolation for memory search#3102

Merged
alteixeira20 merged 2 commits into
odysseus-dev:devfrom
catalini82:test/memory-owner-isolation-search
Jun 11, 2026
Merged

test(memory): cover owner isolation for memory search#3102
alteixeira20 merged 2 commits into
odysseus-dev:devfrom
catalini82:test/memory-owner-isolation-search

Conversation

@catalini82

@catalini82 catalini82 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a small pytest covering memory owner isolation for search. The test verifies that searching as one owner does not return memory entries belonging to another owner.

This follows up on https://github.com/pewdiepie-archdaemon/odysseus/discussions/3101 and keeps the change limited to test coverage only. No source files were modified.

Target branch

  • This PR targets dev.

Linked Issue

Part of #3101

Type of Change

  • Bug fix (non-breaking — fixes a confirmed issue)
  • New feature (non-breaking — adds new behaviour)
  • Breaking change (changes or removes existing behaviour)
  • Refactor / cleanup (behaviour unchanged)
  • Documentation only
  • CI / tooling

Checklist

  • I searched open issues, discussions, and open PRs and did not find a duplicate.
  • This PR targets dev.
  • My changes are limited to one new test file.
  • I ran python -m pytest tests/test_memory_owner_isolation.py -v.
  • I ran python -m py_compile tests/test_memory_owner_isolation.py.

How to Test

python -m pytest tests/test_memory_owner_isolation.py -v
python -m py_compile tests/test_memory_owner_isolation.py

@github-actions github-actions Bot added needs work PR description incomplete — please update before review ready for review Description complete — ready for maintainer review and removed needs work PR description incomplete — please update before review labels Jun 6, 2026
@catalini82

Copy link
Copy Markdown
Contributor Author

Hi @mohd-riaz, this is the small tests-only follow-up to discussion #3101.

I kept it intentionaly narrow: one new pytest covering memory search owner isolation, no source changes, targeting dev.

Quick scope check before CI settles: is search-only the right cut here, or do you want delete covered in the same PR? Happy to split or extend either way.

@mohd-riaz

Copy link
Copy Markdown
Contributor

Thanks for the follow-up. I wasn't involved enough in the original memory isolation changes to give a strong opinion on scope, so I'd rather defer to the maintainers here. The search-only test seems reasonable to me for a focused tests-only PR, though.

@catalini82

Copy link
Copy Markdown
Contributor Author

Makes sense, thanks! Going to keep it search-only and wait on maintainer review then 👍

@alteixeira20 alteixeira20 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM. This is a focused tests-only improvement for memory owner isolation.

The PR adds a regression test proving memory search returns only the caller-owned memory when two owners have matching content. The branch is current, CI is green, and the diff remains limited to the intended test coverage.

@alteixeira20
alteixeira20 merged commit 9d7a3d6 into odysseus-dev:dev Jun 11, 2026
14 checks passed
@catalini82
catalini82 deleted the test/memory-owner-isolation-search branch June 13, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Description complete — ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants