test(memory): cover owner isolation for memory search#3102
Conversation
|
Hi @mohd-riaz, this is the small tests-only follow-up to discussion #3101. I kept it intentionaly narrow: one new pytest covering memory search owner isolation, no source changes, targeting Quick scope check before CI settles: is search-only the right cut here, or do you want delete covered in the same PR? Happy to split or extend either way. |
|
Thanks for the follow-up. I wasn't involved enough in the original memory isolation changes to give a strong opinion on scope, so I'd rather defer to the maintainers here. The search-only test seems reasonable to me for a focused tests-only PR, though. |
|
Makes sense, thanks! Going to keep it search-only and wait on maintainer review then 👍 |
alteixeira20
left a comment
There was a problem hiding this comment.
LGFM. This is a focused tests-only improvement for memory owner isolation.
The PR adds a regression test proving memory search returns only the caller-owned memory when two owners have matching content. The branch is current, CI is green, and the diff remains limited to the intended test coverage.
Summary
Adds a small pytest covering memory owner isolation for search. The test verifies that searching as one owner does not return memory entries belonging to another owner.
This follows up on https://github.com/pewdiepie-archdaemon/odysseus/discussions/3101 and keeps the change limited to test coverage only. No source files were modified.
Target branch
Linked Issue
Part of #3101
Type of Change
Checklist
python -m pytest tests/test_memory_owner_isolation.py -v.python -m py_compile tests/test_memory_owner_isolation.py.How to Test