fix(mcp): sync manage_mcp enable/disable with live manager#3825
Open
cyq1017 wants to merge 4 commits into
Open
fix(mcp): sync manage_mcp enable/disable with live manager#3825cyq1017 wants to merge 4 commits into
cyq1017 wants to merge 4 commits into
Conversation
…isable-runtime-gpt55
…isable-runtime-gpt55
…isable-runtime-gpt55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When enabling or disabling an MCP server via the
manage_mcpcommand/action, the configuration was updated in the database but did not take effect on the activeMCPManagerinstance. This PR connects/disconnects the live MCP server dynamically fromdo_manage_mcpso that changes take effect immediately without needing to restart the application.Target branch
dev, notmain.Linked Issue
Fixes #3824
Type of Change
Checklist
devHow to Test
do_manage_mcpwithaction="disable"and theserver_id. Verify that tools registered by this server are dynamically removed from the active tool registry.do_manage_mcpwithaction="enable"and theserver_id. Verify that tools are dynamically re-registered.python3 -m pytest tests/test_mcp_reconnect_args.pyVisual / UI changes — REQUIRED if you touched anything that renders
N/A (Backend logic only, no UI/visual changes)