fix(diagnostics): use internal_api_base instead of hardcoded port 8000#3827
Open
cyq1017 wants to merge 5 commits into
Open
fix(diagnostics): use internal_api_base instead of hardcoded port 8000#3827cyq1017 wants to merge 5 commits into
cyq1017 wants to merge 5 commits into
Conversation
…ostics-loopback-port-gpt55
…ostics-loopback-port-gpt55
…ostics-loopback-port-gpt55
Collaborator
|
GitHub reports this PR is currently conflicting with |
…ostics-loopback-port-gpt55 # Conflicts: # routes/diagnostics_routes.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/api/test-researchendpoint inroutes/diagnostics_routes.pyhardcoded the port8000(e.g.http://127.0.0.1:8000/v1/chat/completions). If the Odysseus server runs on a custom port or behind a reverse proxy, this endpoint fails.This PR replaces the hardcoded endpoint with the dynamic
internal_api_base()resolution helper. It also updates the regression tests intests/test_internal_api_base.pyto ensure that no hardcoded:7000or:8000are introduced in the future.Target branch
dev, notmain.Linked Issue
Fixes #3826
Type of Change
Checklist
devHow to Test
APP_PORT=7000 uvicorn app:app --port 7000.python3 -m pytest tests/test_internal_api_base.pyVisual / UI changes — REQUIRED if you touched anything that renders
N/A (Backend routes change only, no UI/visual changes)