fix(agent): add holding pattern supervisor detection to prevent conversational stalls#5155
Open
Katsoragi wants to merge 1 commit into
Open
fix(agent): add holding pattern supervisor detection to prevent conversational stalls#5155Katsoragi wants to merge 1 commit into
Katsoragi wants to merge 1 commit into
Conversation
Katsoragi
force-pushed
the
personal/agent-holding-pattern
branch
from
July 12, 2026 15:13
cbdaabf to
1f0f927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds holding pattern supervisor detection to the agent loop to prevent conversational stalls. It detects when the model writes "holding" phrases (e.g., "one moment", "please wait", "I am now reading/searching/fetching...") but ends the turn without executing any tools. It intercepts this and injects a system nudge instructing the model to output the tool call directly, preventing infinite conversational loops.
Target branch
dev, notmain. All PRs land indev;mainis curated by the maintainer at each release. If your PR is onmainby accident, click "Edit" on this PR and change the base.Linked Issue
Fixes #5162
Type of Change
Checklist
devHow to Test
Verify that if the model output contains a holding pattern without a tool call, the supervisor successfully injects a nudge and continues.
Checks Run
pytest tests/test_agent_loop.py tests/test_loop_breaker_runaway.py(All Passed).