Skip to content

fix(mcp): explicit JSONResponse on Windows reconnect (#4533) #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elshayib wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(mcp): explicit JSONResponse on Windows reconnect (#4533) #5381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions routes/mcp_routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import html
from pathlib import Path
from fastapi import APIRouter, Form, HTTPException, Request
from fastapi.responses import RedirectResponse, HTMLResponse
from fastapi.responses import RedirectResponse, HTMLResponse, JSONResponse
import logging
import httpx

Expand Down Expand Up @@ -309,14 +309,15 @@ async def reconnect_server(server_id: str, request: Request):
)

status = mcp_manager.get_server_status(server_id)
return {
payload = {
"connected": connected,
"status": status.get("status", "disconnected"),
"tool_count": status.get("tool_count", 0),
"error": status.get("error"),
"auth_url": status.get("auth_url"),
"needs_auth": status.get("status") == "needs_auth",
}
return JSONResponse(content=payload)
finally:
db.close()

Expand Down