Uniformize mapping of ATNA->FHIR translation #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qligier
force-pushed
the
ql_issue_469
branch
from
87fa982 to
a43ec83
Compare
ohr
reviewed
Apr 19, 2025
| eit.getEventTypeCode().forEach(etc -> | ||
| auditEvent.addSubtype(codedValueTypeToCoding(etc))); | ||
| eit.getEventTypeCode().forEach(etc -> { | ||
| if ("IHE Transactions".equals(etc.getCodeSystemName())) { |
There was a problem hiding this comment.
"IHE Transactions" and "DCM" code system names appears as literal string far too often throughout IPF. Maybe this should be consolidated as public constant in org.openehealth.ipf.commons.audit.types.CodedValueType ?
| if (patReference.getReferenceElement().hasResourceType()) { | ||
| entity.setWhat(new Reference(poit.getParticipantObjectID())); | ||
| if (isNotBlank(poit.getParticipantObjectID())) { | ||
| if (poit.getParticipantObjectTypeCodeRole() == ParticipantObjectTypeCodeRole.Patient) { |
There was a problem hiding this comment.
I cannot remember why this is at all restricted to "Patient" ParticipantObjectTypeCodeRoles. I don't actually see a reason for this distinction.
| } else { | ||
| entity.setWhat(new Reference().setIdentifier( | ||
| new Identifier().setValue(poit.getParticipantObjectID()))); | ||
| final var reference = new Reference().setDisplay(poit.getParticipantObjectID()); |
There was a problem hiding this comment.
See above; otherwise this should also set identifier rather than display
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469
NB1: about the mapping from RoleIDCode to
agent.type, now only the first value is mapped and subsequent ones are lost. We could map additional values toagent.roleif necessary?NB2: about the "IHE Transactions" system: with that fix, we can now generate valid BALP AuditEvents from non-FHIR transactions, but the reverse (generating a valid ATNA AuditMessage from a FHIR transaction) is not true because FHIR transactions directly set the FHIR system, not the DICOM one. I don't know if that's a real usecase.