Skip to content

Fixup RelaxedAtomic operator Types#6896

Open
Disservin wants to merge 1 commit into
official-stockfish:masterfrom
Disservin:relaxed-atomics-cleanup
Open

Fixup RelaxedAtomic operator Types#6896
Disservin wants to merge 1 commit into
official-stockfish:masterfrom
Disservin:relaxed-atomics-cleanup

Conversation

@Disservin

Copy link
Copy Markdown
Member

As pointed out in 0111d11#r188197707, the parameter type should be T not int

@github-actions

Copy link
Copy Markdown

(execution 27359124408 / attempt 1)

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df65475e-0deb-451a-b9fa-7aa09fb8ff71

📥 Commits

Reviewing files that changed from the base of the PR and between 86f1df7 and f025c75.

📒 Files selected for processing (1)
  • src/misc.h

📝 Walkthrough

Walkthrough

This pull request generalizes the RelaxedAtomic<T> template class operators in src/misc.h. The operator+= and operator-= methods now accept a parameter of type T instead of int, enabling direct assignment with values matching the template type. The relaxed-load/relaxed-store implementation logic remains unchanged; only the parameter type signature was modified to improve type safety and eliminate unnecessary implicit conversions.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant