This repository was archived by the owner on Apr 4, 2026. It is now read-only.
fix: sanitize null bytes from messages.body JSON for PostgreSQL#76
Merged
Conversation
Protobuf strings are length-delimited and can contain null bytes. Farcaster Hub accepts casts with null bytes, but PostgreSQL jsonb rejects \u0000 escape sequences. This walks the serde_json::Value tree and strips null bytes from decoded strings, avoiding the pitfall of simple string replacement which can corrupt valid escape sequences like \\u0000.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSQL jsonb rejects
\u0000escape sequences. Protobuf strings are length-delimited and can contain null bytes, which Farcaster Hub accepts. When serialized to JSON via serde_json, null bytes become\u0000and PostgreSQL rejects them.This PR walks the
serde_json::Valuetree and strips null bytes from decoded strings before insertion. This approach avoids the pitfall of simple string replacement which can corrupt valid escape sequences like\\u0000.Changes
sanitize_json_for_postgres()insrc/core/util.rsmessages.bodyJSON in both single and batch insertsTest plan
cargo test sanitizepassescargo clippypasses