This repository was archived by the owner on Apr 4, 2026. It is now read-only.
refactor: mcp#94
Merged
christopherwxyz merged 8 commits intoFeb 22, 2026
Merged
Conversation
- Extract extract_fid, fetch_quoted_casts, fetch_participant_profiles, extract_cast_text helpers in casts.rs to remove repeated patterns - Consolidate set_participant_user_field into users::set_user_data_field - Change get_parent_cast_info to return Option<(Fid, Vec<u8>)> instead of tuple-of-options - Replace current_depth/max_depth with remaining_depth to reduce arg count - Extract build_target_info helper in reactions.rs - Add parse_embed_list utility function - Remove narration comments and dead serde attributes - Fix misleadingly underscore-prefixed parameters that were actually used - Net reduction of ~160 lines Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Combine NullDb relocation (from PR officialunofficial#93) with query layer refactor (PR officialunofficial#94). All imports now use database::NullDb. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors Waypoint query/business logic out of MCP handlers into a new transport-agnostic
WaypointQuerylayer (src/query/*).The MCP layer now acts as a thin protocol adapter (
WaypointMcpTools) that handles request parsing, error mapping, and response serialization, while core query behavior lives in reusable query modules. This separation improves maintainability and enables future adapters (e.g., REST/GraphQL) without duplicating business logic.What Changed
users,casts,reactions,links, plus sharedtypes,responses,utils,error).WaypointQuery.fidparsing).Type of change