fabtests/cuda: cleanup tests and executable names#11889
Merged
shijin-aws merged 3 commits intoofiwg:mainfrom Feb 19, 2026
Merged
fabtests/cuda: cleanup tests and executable names#11889shijin-aws merged 3 commits intoofiwg:mainfrom
shijin-aws merged 3 commits intoofiwg:mainfrom
Conversation
The test checks calling getinfo with FI_HMEM flags. Add fi_ prefix for executable because it uses OFI. Move test to unit/ folder since common/ folder should not have any tests in it Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
Contributor
Author
|
@shijin-aws Cleaning up a bit. Please take a look and let me know if that's ok. I'm tempted to remove the check_hmem test because it doesn't really do anything but I see that you use it in a pytest check so I don't want to break anything for you. |
j-xiong
reviewed
Feb 12, 2026
Contributor
|
aws ci failure: is the PR removing the util binary |
Contributor
Ok I see 08a7167 renamed it. Please update its references as well :) |
Move test to component/dmabuf-rdma since it is a CUDA-direct test targeting dmabuf support Modify test executable name to have cuda prefix to match other iface-specific tests and add that prefix to the gitignore to ignore the binary Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
Contributor
Author
|
@shijin-aws Oops, sorry! Updated! |
Contributor
Author
|
@shijin-aws Ok to merge? |
shijin-aws
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move tests to the appropriate location and add correct prefix so the binaries are ignored.