prov/efa: Clean up efa_hmem_info_init_iface()#11903
Open
charlesstoll wants to merge 1 commit intoofiwg:mainfrom
Open
prov/efa: Clean up efa_hmem_info_init_iface()#11903charlesstoll wants to merge 1 commit intoofiwg:mainfrom
charlesstoll wants to merge 1 commit intoofiwg:mainfrom
Conversation
Cleans up the logic so that the function is easier to read. Changes multiple nested if/else blocks to a single switch statement. Signed-off-by: Charles Stoll <stollcha@amazon.com>
charlesstoll
force-pushed
the
hmem_info_init_refactor
branch
from
352ea55 to
01bfe20
Compare
shijin-aws
reviewed
Feb 20, 2026
|
|
||
| switch (iface) { | ||
| case FI_HMEM_NEURON: | ||
| if (!efa_device_support_rdma_read()) { |
Contributor
There was a problem hiding this comment.
Bump my comment in #11865 (comment). If ofi_hmem_p2p_disabled() is true, we need to warn and fail it early?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the logic so that the function is easier to read. Changes multiple nested if/else blocks to a single switch statement.