fix: JSON marshal errors of parameters with optional structs #1427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced an issue similar to #660 when passing a parameter struct to stdlib slog (using a JSONHandler).
From what I was able to reproduce, the error occurs when calling encoding/json.Marshal on missing optional parameters that that the Opt* struct is used in response types. The problem does not seem to occur if there are no response objects including the optional type (because the Encode/Decode methods are not generated on the Opt* types).
For me the error occurred when using slog with a JSONHandler inside an ogen handler:
Which gives this type of log output:
This PR includes:
OptString
struct #660Notes:
I didn't change the minimum Go version in go.mod