Fix #346 #450
Open
Fix #346 #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
imo it would be nice to also add a test to make sure it works correctly and it doesn't break in the future :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Firstly, thanks for your work on this project!
During testing of my backend I noticed a small issue when comparing timestamps. I stumbled upon an open issue that even mentioned a fix, and it would be nice merge this into the master branch for everyone to use?
All credits go to the author of #346, which also indicates a way to reproduce the issue and mentioned "Worked for me, but should be thoroughly tested with different type combinations.". I have tested various SQL statements I have on my backend and all are working fine now! Although would be nice for someone to confirm if nothing else broke?