RAG notebooks#53
Merged
MichaelClifford merged 15 commits intoogx-ai:mainfrom Apr 9, 2025
Merged
Conversation
The demo should be run as a part of the Llama Stack Playground.
MichaelClifford
suggested changes
Apr 9, 2025
Contributor
MichaelClifford
left a comment
MichaelClifford
left a comment
There was a problem hiding this comment.
Two small comments, otherwise looks good!
Co-authored-by: Michael Clifford <mcliffor@redhat.com>
Co-authored-by: Michael Clifford <mcliffor@redhat.com>
Co-authored-by: Michael Clifford <mcliffor@redhat.com>
Co-authored-by: Michael Clifford <mcliffor@redhat.com>
Shreyanand
reviewed
Apr 9, 2025
Collaborator
Shreyanand
left a comment
Shreyanand
left a comment
There was a problem hiding this comment.
LGTM, minor nit.
For the first notebook, is there an easy way to surface "sources" that were used to create the answer by llamastack? Not a necessity but a nice to have.
Co-authored-by: Shrey <shanand@redhat.com>
Collaborator
Author
|
@Shreyanand Yes, that would be very nice to have for the demo and is definitely an essential feature moving forward. Unfortunately, there is no easy way to add that now. Implementing this feature would require considerable work on the LLS server side. |
3 tasks
MichaelClifford
approved these changes
Apr 9, 2025
Contributor
MichaelClifford
left a comment
MichaelClifford
left a comment
There was a problem hiding this comment.
LGTM 🚀 Thanks @ilya-kolchinsky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the Jupyter notebooks for the direct + agentic RAG demos.