Skip to content

Refactor remove_medication_confirmation i18n key usage code #12070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mnshrm
Copy link
Contributor

@mnshrm mnshrm commented Apr 23, 2025

Proposed Changes

Medication request
image

Medication statement
image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA in Mobile Devices
  • Completion of QA in Desktop Devices

Summary by CodeRabbit

  • Style
    • Improved translation rendering in medication removal confirmation dialogs for better localization support.

Copy link
Contributor

coderabbitai bot commented Apr 23, 2025

Walkthrough

The changes update the way localized strings with dynamic placeholders are rendered in two React components. Specifically, the code replaces the use of the t function for translations with the Trans component from "react-i18next" in the medication removal confirmation dialogs. This adjustment affects how the medication name is interpolated within the translated message, aligning the implementation with recommended i18n practices. No other logic, control flow, or exported/public entity declarations were modified.

Changes

File(s) Change Summary
src/components/Questionnaire/QuestionTypes/MedicationRequestQuestion.tsx Switched from using t function to <Trans> component for rendering the medication removal confirmation translation.
src/components/Questionnaire/QuestionTypes/MedicationStatementQuestion.tsx Replaced usage of t function with <Trans> component for the medication removal confirmation dialog translation.

Assessment against linked issues

Objective Addressed Explanation
Refactor remove_medication_confirmation i18n key to use Trans component instead of t function in specified components (#11957)
Ensure dynamic values for placeholders are passed using Trans component as per i18n rules (#11957)

Suggested labels

needs review, Tested ✅

Suggested reviewers

  • Jacobjeevan
  • amjithtitus09

Poem

A hop and a skip through the i18n field,
With Trans in our paws, the old ways we yield.
Medications named, now clear as the sun,
Our translations are tidy, the refactor is done!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8d5ca0 and 030762a.

📒 Files selected for processing (2)
  • src/components/Questionnaire/QuestionTypes/MedicationRequestQuestion.tsx (2 hunks)
  • src/components/Questionnaire/QuestionTypes/MedicationStatementQuestion.tsx (2 hunks)
🔇 Additional comments (4)
src/components/Questionnaire/QuestionTypes/MedicationRequestQuestion.tsx (2)

6-6: Good addition of Trans component import

Adding the Trans component import is essential for the i18n key handling improvement in this PR.


345-352: Properly implemented Trans component for i18n interpolation

This change replaces the direct t-function call with the Trans component, which is a best practice for handling i18n keys with interpolated values. The Trans component ensures that translation tools properly scan and preserve these keys, especially when they contain dynamic content like medication names.

src/components/Questionnaire/QuestionTypes/MedicationStatementQuestion.tsx (2)

5-5: Good addition of Trans component import

Adding the Trans component import is essential for the i18n key handling improvement in this PR.


234-241: Properly implemented Trans component for i18n interpolation

This change replaces the direct t-function call with the Trans component, which is a best practice for handling i18n keys with interpolated values. The Trans component ensures that translation tools properly scan and preserve these keys, especially when they contain dynamic content like medication names.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit ad45f08
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6810fc3903bf0c000881ea86
😎 Deploy Preview https://deploy-preview-12070.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…issues/11957/refactor-medication-i18n-keys
@mnshrm mnshrm marked this pull request as ready for review April 27, 2025 14:59
@mnshrm mnshrm requested a review from a team as a code owner April 27, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor remove_medication_confirmation i18n key in MedicationRequestQuestion.tsx and other components
1 participant