-
Notifications
You must be signed in to change notification settings - Fork 995
fix: Remove 'intersects_any' from 'ConditionOperation' type enum(#14408) #15093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: Remove 'intersects_any' from 'ConditionOperation' type enum(#14408) #15093
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughRemoved the Changes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview Deployment Ready!
This preview will be automatically updated when you push new commits to this PR. |
🎭 Playwright Test ResultsStatus: ✅ Passed
📊 Detailed results are available in the playwright-final-report artifact. Run: #4562 |
576902d to
9bacdb8
Compare
9bacdb8 to
92bccea
Compare
Proposed Changes
Fixes #14408
Tagging: @ohcnetwork/care-fe-code-reviewers
@Jacobjeevan @yash-learner
Merge Checklist
Checks:
intersects_anyin theallowed_operationslist. Therefore, the UI dropdowns (which rely on this list) will never display it.condition.ts(used for form validation) already excludedintersects_any, only allowingequality,in_range, andhas_tag.equality, in_range, and has_tag. It does not have logic forintersects_any, so removing it from the type definition cleans up dead code that would never be reachable.grep -r "intersects_any" .confirms the string "intersects_any" does not exist anywhere else in the codebase.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.