Potential fix for code scanning alert no. 2: Uncontrolled data used in path expression #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ohgodwhy2k/quicksite/security/code-scanning/2
To fix the issue, we should prevent path traversal by making sure all file access is constrained to the
DIST_ROOTdirectory. The steps are:..is resolved.DIST_ROOT) and ensure the resolved path is always within it, by checking that the final, normalized resolved path starts with (or equals) the absolute root.Implement these changes in
scripts/serve.js, by:resolvefromnode:path.DIST_ROOTand the requested user path to their absolute versions usingpath.resolve().No other functionality should change; file serving and MIME type detection remain as in the original.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.