Potential fix for code scanning alert no. 1: Uncontrolled data used in path expression #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ohgodwhy2k/quicksite/security/code-scanning/1
To fix the problem, we need to validate the path derived from user input such that only files strictly underneath the project's
DIST_ROOTcan be served. This is best done by:path.resolve()(after joining with the root), canonicalizing removal of.., etc.DIST_ROOT.Update the
scripts/serve.jsin the handler for requests:DIST_ROOTonce.path.resolve(), using canonicalDIST_ROOTas the base.You will also need to add an import for
resolveandnormalizeif not already present (althoughresolveis available fromnode:path).Suggested fixes powered by Copilot Autofix. Review carefully before merging.