Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #937

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update README.md #937

wants to merge 2 commits into from

Conversation

thromera
Copy link

@thromera thromera commented Aug 19, 2024 •
edited
Loading

Clarifications for the first example in the readme:

  • remove unneeded complex hash in comments
  • update the return value of the puts to match what actually would be displayed.

@thromera
Update README.md
27fcc6a 
Clarifications for the example, removed not-needed complex hash in comments + comparison was missing`Same?` part.
@thromera
Update README.md
32ab093 
Actually remove the `Same?` part, jsut display comparison of h && h2
ohler55
ohler55 requested changes Sep 9, 2024
View reviewed changes
Copy link
Owner

@ohler55 ohler55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad to simply use h == h2 but I prefer to include the output from Oj.dump so it's clear what the JSON would look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohler55 ohler55 ohler55 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thromera @ohler55