Conversation
…. Update usage documentation and tests accordingly.
…functions. Added detailed logging for connection duration, input length, and command execution state. Updated documentation to reflect new logging behavior for successful and incomplete connections.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates tcpserver’s logging behavior to be safer and more operationally useful by avoiding logging raw connection payloads, adding connection-level summary logs, and refining CLI flags to control log verbosity.
Changes:
- Replace
-v/--verbosewith-q/--quiet(WARN) and--debug(DEBUG overrides quiet). - Add per-connection summary logging with duration/size/process metrics; log per-line length instead of line content.
- Update flag parsing tests and the behavioral spec to match the new logging/flag behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
SPEC.md |
Updates CLI and logging behavior spec, including new flag semantics and summary log fields. |
main.go |
Implements quiet/debug flags, safer debug logging (lengths), and deferred connection summaries. |
main_test.go |
Updates/extends flag parsing tests for the new quiet/debug flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.