Repository navigation
Use public function get_option_name instead of static value - #668
Merged
Merged
Conversation
As get_option_name is public any child classes may implement get_option_name however currently this will not do what is intended due to accessing the property directly in the parent functions. Fixes: oidc-wp#667
daggerhart
approved these changes
Nov 17, 2026
Collaborator
|
Thanks for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As get_option_name is public any child classes may implement get_option_name however currently this will not do what is intended due to accessing the property directly in the parent functions.
All Submissions:
Changes proposed in this Pull Request:
Closes #667 .
How to test the changes in this Pull Request:
get_option_namefunction that returns a new stringOPTION_NAMEis stored / loggedThe existing tests should provide necessary coverage here to avoid any regression.
Changelog entry
Fix:
get_option_namein class functions instead ofself::OPTION_NAMEto ensure the correct value is used if subclassed.