Repository navigation
Add WooCommerce login button placement and auto login - #684
Open
unknowndomain wants to merge 3 commits into
Open
unknowndomain wants to merge 3 commits into
unknowndomain wants to merge 3 commits into
Conversation
Adds a WooCommerce Login setting: - Do not add (default, existing sites are unchanged). - Top or Bottom of the login form: adds the login button with an "or" divider to WooCommerce's login forms (My Account and the checkout "Returning customer" form), returning users to the page they came from. - Auto Login - SSO: logged out visitors to My Account go straight to the identity provider, like Auto Login for wp-login.php. The lost password form is kept, and WooCommerce's default logout redirect goes to the home page so users are not sent straight back to the identity provider. Only WooCommerce's own hooks are used, so nothing happens on sites without WooCommerce. Fixes oidc-wp#93 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Liup3HxEjjGAyXaA1RZLbY
Collaborator
|
Thanks for this, and for including tests. It changes login and redirect behavior, so it needs a closer review than the current release allows. Leaving it open for now. |
Author
|
Makes sense, we're now using it in production at southlondonmakerspace.org from the fork, so hopefully we'll pick up any early issues before the next release/opportunity to review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Hi again! This is the second change from our site. Lots of sites add the login button to WooCommerce's login form with their own code, so we've made it a setting.
This adds a WooCommerce Login setting with four options:
It only uses WooCommerce's own hooks, so it does nothing on sites without WooCommerce. #241 took a hook based approach to the same need; this makes it a setting instead.
Closes #93.
How to test the changes in this Pull Request:
Other information:
The full PHPUnit suite passes (72 tests) and PHPCS is clean. Written with help from Claude.
Changelog entry
🤖 Generated with Claude Code
https://claude.ai/code/session_01Liup3HxEjjGAyXaA1RZLbY