Skip to content

Conversation

@zonca
Copy link
Member

@zonca zonca commented Aug 21, 2025

  • Fix: Remove unsupported setuptools_scm local_scheme
  • Git: Ignore uv.lock

zonca added 2 commits August 21, 2025 13:39
The `pyproject.toml` file contained `local_scheme = "no-local"` under
`[tool.setuptools_scm]`. This value is not a recognized or supported
local scheme by `setuptools_scm`, leading to build errors.

The correct value to achieve the desired behavior of omitting local
version identifiers is `no-local-version`. However, the original intent
of using `no-local` is unclear, and simply removing the unsupported
line resolves the build issue.

This line was introduced in commit f6240a1 ("Major updates to codebase,
not a meaningful stage. Need to remove CRDS deps").

This commit removes the problematic `local_scheme = "no-local"`
configuration.
Add uv.lock to .gitignore to prevent it from being tracked.
@zonca zonca requested a review from astrobc1 August 21, 2025 20:43
@zonca zonca force-pushed the fix/setuptools-scm-local-scheme branch from 7772ab7 to 425f32c Compare August 21, 2025 22:26
Copy link
Contributor

@astrobc1 astrobc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here too, and thanks for the extra info on how setuptools manages version schemes.

@zonca zonca merged commit 3d0ac2e into oirlab:master Aug 25, 2025
2 checks passed
@zonca zonca deleted the fix/setuptools-scm-local-scheme branch August 25, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants