feat: add TodoMVC example with identity contracts and KV store#66
feat: add TodoMVC example with identity contracts and KV store#66akhileshthite wants to merge 2 commits intofeature/chel-dxfrom
Conversation
|
This looks like a good start. I left some accessibility-related comments that, while they are issues in the code this is based on (i.e., the other TODO MVC examples), there's maybe little reason to replicate here. I think that to simplify things, up to you, it's fine to use a CDN for importing I see that you're adding login functionality. This part will likely be the most complex aspect of this MVC, since login currently takes several steps, but it'll also be a good opportunity to see how simple we can make it. |
f75f20f to
981d89a
Compare
|
The TodoMVC uses SBP (@sbp/sbp@2.4.1) and Chelonia (@chelonia/lib@1.2.2) libraries loaded from CDN with localStorage as the storage backend for browser compatibility. Also, the custom Chelonia's KV store ( We still benefit by loading Chelonia because it validates our architecture patterns match real Chelonia (same Q: How should I approach this? Any guidance on the recommended path forward would be greatly appreciated! |
|
I've taken a look at this again, and these are some thoughts:
ETA: On this same note, I can see why maybe things got confused, but |
Somehow, I missed this. I'm not sure what you mean here by ' |
todomvc.mp4