Enhance Change Request UI: Streamline Merge Options and Fix Commit Links#164
Draft
Enhance Change Request UI: Streamline Merge Options and Fix Commit Links#164
Conversation
…streamline fork/article UI, and implicitly delete branches after PR merge.
…d pull request commit linking.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: Pierre Schweiger <schweiger.pierre@gmail.com>
Collaborator
Author
|
/crush_fast AI review started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request simplifies the Change Request view and fixes broken commit differential links.
Resolves #160
Key changes include:
Removed Branch Dropdown Select (editing CR title): The ability to change base/head branches while editing the title has been disabled via a custom view_title.tmpl override to prevent workflow confusion.
Enforced Default "Delete Branch" on Merge: Modified the PullRequestMergeForm.vue component to remove the "Delete Branch" checkbox line. The value is now enforced via a hidden input element, making post-merge branch deletion default behavior.
Removed "Deleted Branch" Timeline Comment: Created a custom override for
comments.tmpl
to suppress the "branch was deleted at X" timeline event message.
Removed Git CLI Instructions: The "View command line instructions" button and its associated instructions template were removed from the custom
pull_merge_box.tmpl
template.
Fixed Commit Anchor Links: Commit links inside Change Requests previously pointed to a global /commit/{hash} route, which does not exist for articles. We've overridden
commits_list.tmpl
and
commits_list_small.tmpl
, and updated
comments.tmpl
to direct users to the native PR diff view (/pulls/{index}/commits/{hash}) when viewing from a PR context.
Co-authored by: Claude Opus 4.6, Gemini 3.1 Pro