Conversation
Member
|
Also, could this PR add support for sync progress? It would be great if we could display a progress bar along with a timer so that the user knows about how long it'll take for the sync to finish. E.g. even though we don't know exactly the size of the full sync in advance, we do know how quickly we are syncing each message, and since on average most messages will have an average size, and since we know how many messages there are left to sync, we can estimate a completion time. EDIT: here's an example of a progress bar that combines the progress of all currently syncing contracts. It shows which message we're on for one of the contracts (e.g. the identity.js contract), as well as which contract we're on:
|
corrideat
force-pushed
the
user-local-snapshots
branch
2 times, most recently
from
8b2e7a5 to
b09fa62
Compare
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
user-local-snapshots
|
| Run status |
|
| Run duration | 13m 14s |
| Commit |
|
| Committer | Ricardo Iván Vieitez Parra |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
114
|
| View all changes introduced in this branch ↗︎ | |
corrideat
force-pushed
the
user-local-snapshots
branch
from
b09fa62 to
dc33a1c
Compare
corrideat
force-pushed
the
user-local-snapshots
branch
from
dc33a1c to
93eafd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the goal of speeding up login by: