Skip to content

Fix form label #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avdata99 merged 2 commits into from
Nov 25, 2025
Merged

Fix form label #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaff330
Fix form label
avdata99 Nov 25, 2025
89ca613
Fix how we get actual data
avdata99 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ckanext/activityinfo/blueprints/activity_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def form(database_id, form_id):
'data': data,
'form': form,
'database_id': schema['databaseId'],
'database': {'label': 'Test DB'},
'fields': fields,
}
return toolkit.render('activity_info/form_details.html', extra_vars)
Expand Down
2 changes: 1 addition & 1 deletion ckanext/activityinfo/data/samples/form-tree-translated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"id": "FORM-ID",
"schemaVersion": 1,
"databaseId": "DATABASE-ID",
"label": "RIDL Form",
"label": "Label Form",
"elements": [
{
"id": "cbgn1gumhum9w5s4",
Expand Down
2 changes: 1 addition & 1 deletion ckanext/activityinfo/templates/activity_info/form_details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

{% block primary_content %}
<div class="internal-div-section">
<h1>Form <i>{{ form.label }}</i> for database <i>{{ database.label }}</i></h1>
<h1>Form <i>{{ form.schema.label }}</i></h1>

<table id="activity-info-form-schema" class="table table-header table-hover table-bordered table-responsive">
<thead>
Expand Down
2 changes: 1 addition & 1 deletion ckanext/activityinfo/tests/test_ui_form.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ def test_form_success(self, app, ai_user_with_api_key):
fake_database_id = "db01"
fake_form = {
"id": fake_form_id,
"label": "Form label 01",
"schema": {
"databaseId": fake_database_id,
"label": "Form label 01",
"elements": [
{"code": "field1", "label": "Field 1"},
{"code": "field2", "label": "Field 2"}
Expand Down