Open
Conversation
germankay
approved these changes
Feb 25, 2026
Collaborator
|
@pdelboca I tested the entire IATI file loading and generation process locally and it worked correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a long-overdue cleanup of the codebase. The code removed is no longer required and it is messing around with the documentation tasks.
What is being removed?
The extension shouldn't use the database for IATIFiles as we are not tracking information nor we need to persist anything. The flow of the extension should be simple:
We do not store invalid activity files, we are not validating any independent IATIFileType and we do not track attempts to generate activity/organisation files.
Therefore, there is no need to have a database table for this extension.