Skip to content

Fix-2023 #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2025
Merged

Fix-2023 #2024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17b8096
Fixes #2023
okorach-sonar Oct 25, 2025
4aeb7ff
Add test import file
okorach-sonar Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sonar/branches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,11 @@ def set_keep_when_inactive(self, keep: bool) -> bool:
:return: Whether the operation was successful
"""
log.info("Setting %s keep when inactive to %s", self, keep)
if self.is_main():
if not keep:
log.warning("%s is main branch, can't be purgeable, skipping...", str(self))
raise exceptions.UnsupportedOperation(f"{str(self)} is the main branch, can't be purgeable")
return True
ok = self.post("project_branches/set_automatic_deletion_protection", params=self.api_params() | {"value": str(keep).lower()}).ok
if ok:
self._keep_when_inactive = keep
Expand Down Expand Up @@ -285,7 +290,10 @@ def import_config(self, config_data: types.ObjectJsonRepr) -> None:
log.debug("Importing %s with %s", str(self), config_data)
if config_data.get("isMain", False):
self.set_as_main()
self.set_keep_when_inactive(config_data.get("keepWhenInactive", False))
try:
self.set_keep_when_inactive(config_data.get("keepWhenInactive", False))
except exceptions.UnsupportedOperation as e:
log.warning(e.message)
if settings.NEW_CODE_PERIOD in config_data:
new_code = settings.string_to_new_code(config_data[settings.NEW_CODE_PERIOD])
param = None
Expand Down
Loading