Skip to content

Replace-boolean-strings-by-their-values #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2025
Merged

Replace-boolean-strings-by-their-values #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5ef5ce
Improve type conversion function
okorach-sonar Nov 2, 2025
690518f
Convert boolean strings to their values
okorach-sonar Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sonar/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,11 +207,11 @@ def reload(self, data: types.ApiPayload) -> None:
elif self.key == COMPONENT_VISIBILITY:
self.value = data.get("visibility", None)
elif self.key == "sonar.login.message":
self.value: Optional[Any] = None
self.value = None
if "values" in data and isinstance(data["values"], list) and len(data["values"]) > 0:
self.value = data["values"][0]
else:
self.value = next((data[key] for key in ("fieldValues", "values", "value") if key in data), None)
self.value = util.convert_to_type(next((data[key] for key in ("fieldValues", "values", "value") if key in data), None))
if not self.value and "defaultValue" in data:
self.value = util.DEFAULT
self.__reload_inheritance(data)
Expand Down
8 changes: 7 additions & 1 deletion sonar/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,10 @@ def redacted_token(token: str) -> str:
return re.sub(r"(..).*(..)", r"\1***\2", token)


def convert_to_type(value: Any) -> Any:
def convert_to_type(value: str) -> Any:
"""Converts a potentially string value to the corresponding int or float"""
if not isinstance(value, str):
return value
try:
return int(value)
except ValueError:
Expand All @@ -169,6 +171,10 @@ def convert_to_type(value: Any) -> Any:
return float(value)
except ValueError:
pass
try:
return bool(value)
except ValueError:
pass
return value


Expand Down