This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Feat/share data step 3 validation#494
Draft
loiclaudet wants to merge 2 commits into
Draft
Conversation
bot-anik
reviewed
Oct 4, 2023
Member
There was a problem hiding this comment.
| Device | URL |
|---|---|
| desktop | http://localhost:4173/ |
| Device | URL |
|---|---|
| mobile | http://localhost:4173/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
5d61ca1 to
60b2011
Compare
60b2011 to
502f514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The user can currently reach step 4 although the dataset title field is required in step 3.
This PR add text field validation for shareData step 3.
TODO