Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Feat/share data step 3 validation#494

Draft
loiclaudet wants to merge 2 commits into
mainfrom
feat/share-data-step3-validation
Draft

Feat/share data step 3 validation#494
loiclaudet wants to merge 2 commits into
mainfrom
feat/share-data-step3-validation

Conversation

@loiclaudet

@loiclaudet loiclaudet commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Purpose

The user can currently reach step 4 although the dataset title field is required in step 3.

This PR add text field validation for shareData step 3.

TODO

  • Error handling - We need more details about errors management.

@loiclaudet loiclaudet added the feature 🤌 new features label Oct 4, 2023
@loiclaudet loiclaudet self-assigned this Oct 4, 2023

@bot-anik bot-anik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://localhost:4173/

Device URL
mobile http://localhost:4173/

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@loiclaudet loiclaudet force-pushed the feat/share-data-step3-validation branch 2 times, most recently from 5d61ca1 to 60b2011 Compare October 5, 2023 07:04
@loiclaudet loiclaudet marked this pull request as draft October 5, 2023 13:25
@loiclaudet loiclaudet force-pushed the feat/share-data-step3-validation branch from 60b2011 to 502f514 Compare October 6, 2023 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature 🤌 new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants