p3 in homme #16
Open
p3 in homme #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Commit 7de2632 can be used as a "baseline" to track changes into p3 source files. This commit finalized the move of p3 source files into homme with only bare mandatory changes. The other changes (including debug statements) could potentially touch p3 source files, so best is to run diffs to make sure the changes do not alter p3 code. |
oksanaguba
commented
Mar 6, 2025
| real(rl) :: gamma ! coefficient for latent heat computation, gamma = Lvap / (Cp * exner) | ||
| real(rl) :: T ! temperature [K] | ||
| logical :: is_saturated | ||
| integer :: ii, jj, kk |
Owner
Author
There was a problem hiding this comment.
i also name my indices like that :)
…ted it into a column p3 proc), fix bug in computing FQ (added pdel factor), fix bug in simple qsat adj for using proper rho_water, fix dtime in p3, switch to adjustment of dp3d in forcing
Autoconversion and accretion: cleanup namelists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open this as a way to browse changes