Update Angular to v16, support v16 - v19 #163
Conversation
| @@ -0,0 +1,47 @@ | |||
| { | |||
There was a problem hiding this comment.
Seems like there are few rules from the old files missing here
There was a problem hiding this comment.
the import rule is handled implicitly now (i tested with adding a rando import).
Jest is added to the spec file config
I haven't checked the node one though, but not sure it is needed (which node scripts are we worried about?) also the plugin hasn't been updated since 2020... maybe this is for e2e???
| "auth", | ||
| "oauth2" | ||
| ], | ||
| "exports": { |
There was a problem hiding this comment.
Why was this removed?
There was a problem hiding this comment.
Have you looked into merging this package.json with the top-level one?
There was a problem hiding this comment.
it's handled with the new version of Angular. I double checked the package.json in the dist dir
(there's also a warning in the console if you leave it)
There was a problem hiding this comment.
sorry, just saw your second comment.
i'm not sure i understand the question. this is the package.json we distribute, so i'd think we wouldn't want to combine it with the root project level one. (i bet APF wouldn't handle that merging well anyway)
There was a problem hiding this comment.
Right now we have
package.json
lib/package.json
lib/src/..
Ideally I'd like to combine these into a single package.json and src dir. But if that is not possible that's fine (aka get rid of the lib dir)
There was a problem hiding this comment.
yeah, that's not possible as ng-packgr expects a sibling package.json to include in the lib.
the dir doesnt have to be named lib though, but it will need to be organized into a directory
|
opening this PR and finding out how much change the version bump required is like
|
3 participants
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Bump min version of Angular supported
What is the current behavior?
Doesn't support Angular v17 - v19
Issue Number: N/A
What is the new behavior?
Support Angular v17 - v19
Does this PR introduce a breaking change?
Other information
Reviewers