fix: register with useGenericRemediator

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 7.4.3
+
+- [#1457](https://github.com/okta/okta-auth-js/pull/1457) Fix: `flow: register` now works with `useGenericRemediator: true`
+
 ## 7.4.2
 
 ### Bug Fix

lib/idx/flow/FlowSpecification.ts

@@ -15,14 +15,20 @@ export interface FlowSpecification {
 // eslint-disable-next-line complexity
 export function getFlowSpecification(
   oktaAuth: OktaAuthIdxInterface,
-  flow: FlowIdentifier = 'default'
+  flow: FlowIdentifier = 'default',
+  useGenericRemediation = false
 ): FlowSpecification {
   let remediators, actions, withCredentials = true;
   switch (flow) {
     case 'register':
     case 'signup':
     case 'enrollProfile':
       remediators = RegistrationFlow;
+      if (useGenericRemediation) {
+        actions = [
+          'select-enroll-profile'
+        ];
+      }
       withCredentials = false;
       break;
     case 'recoverPassword':

lib/idx/run.ts

@@ -81,6 +81,7 @@ function initializeData(authClient, data: RunData): RunData {
     withCredentials,
     remediators,
     actions,
+    useGenericRemediator
   } = options;
 
   const status = IdxStatus.PENDING;
@@ -89,7 +90,7 @@ function initializeData(authClient, data: RunData): RunData {
   flow = flow || authClient.idx.getFlow() || 'default';
   if (flow) {
     authClient.idx.setFlow(flow);
-    const flowSpec = getFlowSpecification(authClient, flow);
+    const flowSpec = getFlowSpecification(authClient, flow, useGenericRemediator);
     // Favor option values over flow spec
     withCredentials = (typeof withCredentials !== 'undefined') ? withCredentials : flowSpec.withCredentials;
     remediators = remediators || flowSpec.remediators;

package.json

@@ -2,7 +2,7 @@
   "private": true,
   "name": "@okta/okta-auth-js",
   "description": "The Okta Auth SDK",
-  "version": "7.4.2",
+  "version": "7.4.3",
   "homepage": "https://github.com/okta/okta-auth-js",
   "license": "Apache-2.0",
   "main": "build/cjs/exports/default.js",

scripts/lint.sh

@@ -1,4 +1,4 @@
-#!/bin/bash -e
+#!/bin/bash
 
 source ${OKTA_HOME}/${REPO}/scripts/setup.sh
 

scripts/publish.sh

@@ -1,4 +1,4 @@
-#!/bin/bash -xe
+#!/bin/bash -x
 
 source ${OKTA_HOME}/${REPO}/scripts/setup.sh
 

test/spec/idx/run.ts

@@ -156,7 +156,7 @@ describe('idx/run', () => {
       const { authClient } = testContext;
       jest.spyOn(mocked.FlowSpecification, 'getFlowSpecification');
       await run(authClient, { flow: 'signup' });
-      expect(mocked.FlowSpecification.getFlowSpecification).toHaveBeenCalledWith(authClient, 'signup');
+      expect(mocked.FlowSpecification.getFlowSpecification).toHaveBeenCalledWith(authClient, 'signup', undefined);
     });
   });
 
@@ -232,8 +232,9 @@ describe('idx/run', () => {
       password, 
       stateHandle: idxResponse.rawIdxState.stateHandle 
     };
-    const flowSpec = mocked.FlowSpecification.getFlowSpecification(authClient, flow);
+    const flowSpec = mocked.FlowSpecification.getFlowSpecification(authClient, flow, options.useGenericRemediator);
     const { remediators, actions, flowMonitor } = flowSpec;
+    expect(actions).toEqual(['select-enroll-profile']);     // GenericRemediator now returns register as action
     await run(authClient, options);
     expect(mocked.remediate.remediate).toHaveBeenCalledWith(authClient, idxResponse, values, {
       remediators,
@@ -267,7 +268,7 @@ describe('idx/run', () => {
       password, 
       stateHandle: idxResponse.rawIdxState.stateHandle 
     };
-    const flowSpec = mocked.FlowSpecification.getFlowSpecification(authClient, flow);
+    const flowSpec = mocked.FlowSpecification.getFlowSpecification(authClient, flow, true);
     const { remediators, actions, flowMonitor } = flowSpec;
     await run(authClient, options);
     expect(mocked.remediate.remediate).toHaveBeenCalledWith(authClient, idxResponse, values, {