Detect origin for urls of different forms#1538
Open
inc-osaulenko wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for the submission! Internal Ref: OKTA-805980 |
|
Hello! Any updates on this? When it can be merged? |
|
Hi team, It’s been nearly two years since this feature request was accepted for review, but there haven’t been any updates. Can you please provide an update on its status and whether it is still being considered for implementation? This functionality is important for our mutual customers, and the lack of visibility makes planning difficult. Any guidance would be appreciated. |
Contributor
|
We will need a signed CLA by the author in order to merge this. This PR also needs tests before it can be accepted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, origin is detected by taking the part of URL prior to
/oauth2/and for URLs like thisIt works as expected. However, when the service that uses OKTA API is behind a multi-tenant proxy and URL will be like
It doesn't work. There is an option to do the same thing using
(new URL('...')).originbut that will require to add another polyfill for IE11. This one usesArray.prototype.splitwhich is available in IE11 and requires no polyfill.