Scope Handlebars dependencies to OpenAPI generator plugin #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The built artifacts do not depend on Handlebars (at least not according to `jdeps`), nor do any of this project's other dependencies. The version of Handlebars required by this constraint is only compatible with JDK 17 and upwards; this project would otherwise be compatible with earlier JDKs. Since the dependency is actually unused by the Okta SDK, the incompatibility with JDK 11 is a bit subtle: it will only manifest in applications that are themselves using Handlebars at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
N/A
Description
The version of Handlebars required by this project is only compatible with JDK 17 and upwards; the artifacts built by this project would otherwise be compatible with earlier JDKs. Since the dependency is actually unused by the Okta SDK, the incompatibility with JDK 11 is a bit subtle: it will only manifest in applications that are themselves using Handlebars at runtime.
The SDK's built artifacts do not depend on Handlebars (checked with
jdeps), nor do any of this project's other dependencies (checked withcoursier resolve).Category
Signoff