Skip to content

Detect localisation sync issues for password requirements#3606

Draft
denysoblohin-okta wants to merge 6 commits into
masterfrom
od-sync-messages-OKTA-412696
Draft

Detect localisation sync issues for password requirements#3606
denysoblohin-okta wants to merge 6 commits into
masterfrom
od-sync-messages-OKTA-412696

Conversation

@denysoblohin-okta

@denysoblohin-okta denysoblohin-okta commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Description:

SIW has a logic to remove translated part of password complexity requirements from server error response:

fn.removeRequirementsFromError = function(responseJSON, policy) {
const passwordRequirementsAsString = this.getPasswordComplexityDescription(policy);
if (
responseJSON.errorCauses &&
responseJSON.errorCauses.length > 0 &&
_.isString(responseJSON.errorCauses[0].errorSummary)
) {
responseJSON.errorCauses[0].errorSummary = responseJSON.errorCauses[0].errorSummary
.replace(passwordRequirementsAsString, '')
.trim();
}
return responseJSON;
};

But some translations are not in sync.
This PR adds a script to verify and/or fix translations issues.

yarn verify-translations
yarn verify-translations --write

PR Checklist

Issue:

Reviewers:

Screenshot/Video:

Downstream Monolith Build:

@denysoblohin-okta
denysoblohin-okta force-pushed the od-sync-messages-OKTA-412696 branch from 69163fc to af55036 Compare May 2, 2024 15:18
@denysoblohin-okta
denysoblohin-okta force-pushed the od-sync-messages-OKTA-412696 branch from af55036 to 41ce2d7 Compare July 9, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant