feat: add DPoP bound access tokens to OAuth apps#2834
Open
laurynas-jonusas wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for managing
settings.oauthClient.dpop_bound_access_tokensonokta_app_oauth. This exposes DPoP-bound access token configuration for OIDC applications via the newdpop_bound_access_tokensargument. This also fixes sort of a bug, because if you were to import existing application that has DPoP as true and then for example addenduser_notefield with a value, it would silently drop DPoP to false.Changes
dpop_bound_access_tokensto theokta_app_oauthresource schema.settings.oauthClienton create/update when configured, and preserves existing state when omitted.Testing
Also tested manually with a locally built binary using dev overrides. Verified that
okta_app_oauthacceptsdpop_bound_access_tokens, applies the value to an OAuth app, and preserves the existing value when the argument is omitted from config.