Skip to content

Conversation

@rberrelleza
Copy link
Member

@rberrelleza rberrelleza commented May 16, 2025

This PR hads a "rental history" log API to the demo. This is so that we can have a more obvious use for the 'Volume Snapshots' feature. You can see it by going to "Admin" button on the top right, or to https://movies-pr-133-cindylopez.demo.okteto.dev/admin/rentals-history

@github-actions
Copy link

github-actions bot commented May 16, 2025

deploy:
- name: Deploy PostgreSQL
command: okteto deploy -f postgresql/okteto.yaml
command: okteto deploy -f postgresql/okteto.yaml --var DB_SNAPSHOT_NAME=$DB_SNAPSHOT_NAME --var DB_SNAPSHOT_NAMESPACE=$DB_SNAPSHOT_NAMESPACE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we feel like it's better to have a second okteto.yaml for the volumes, or do we keep it here? I'm concerned that this might make it look more complicated than it is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rberrelleza As it is now, it can be used for future divert scenarios. I mean, if you need to deploy the database in different manifests (the whole app + some specific service for divert), it is better to have a separated manifest to have all the logic there, instead of having to copy the helm command in the different manifest.

But, for what we have today, moving it here might be the best. We can always figure out what is bets when we prepare divert samples

deploy:
- name: Deploy PostgreSQL
command: okteto deploy -f postgresql/okteto.yaml
command: okteto deploy -f postgresql/okteto.yaml --var DB_SNAPSHOT_NAME=$DB_SNAPSHOT_NAME --var DB_SNAPSHOT_NAMESPACE=$DB_SNAPSHOT_NAMESPACE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rberrelleza As it is now, it can be used for future divert scenarios. I mean, if you need to deploy the database in different manifests (the whole app + some specific service for divert), it is better to have a separated manifest to have all the logic there, instead of having to copy the helm command in the different manifest.

But, for what we have today, moving it here might be the best. We can always figure out what is bets when we prepare divert samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants