-
Notifications
You must be signed in to change notification settings - Fork 156
Add API for transaction log #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Your preview environment pr-133-cindylopez has been deployed. Preview environment endpoints are available at: |
| deploy: | ||
| - name: Deploy PostgreSQL | ||
| command: okteto deploy -f postgresql/okteto.yaml | ||
| command: okteto deploy -f postgresql/okteto.yaml --var DB_SNAPSHOT_NAME=$DB_SNAPSHOT_NAME --var DB_SNAPSHOT_NAMESPACE=$DB_SNAPSHOT_NAMESPACE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we feel like it's better to have a second okteto.yaml for the volumes, or do we keep it here? I'm concerned that this might make it look more complicated than it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rberrelleza As it is now, it can be used for future divert scenarios. I mean, if you need to deploy the database in different manifests (the whole app + some specific service for divert), it is better to have a separated manifest to have all the logic there, instead of having to copy the helm command in the different manifest.
But, for what we have today, moving it here might be the best. We can always figure out what is bets when we prepare divert samples
| deploy: | ||
| - name: Deploy PostgreSQL | ||
| command: okteto deploy -f postgresql/okteto.yaml | ||
| command: okteto deploy -f postgresql/okteto.yaml --var DB_SNAPSHOT_NAME=$DB_SNAPSHOT_NAME --var DB_SNAPSHOT_NAMESPACE=$DB_SNAPSHOT_NAMESPACE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rberrelleza As it is now, it can be used for future divert scenarios. I mean, if you need to deploy the database in different manifests (the whole app + some specific service for divert), it is better to have a separated manifest to have all the logic there, instead of having to copy the helm command in the different manifest.
But, for what we have today, moving it here might be the best. We can always figure out what is bets when we prepare divert samples
This PR hads a "rental history" log API to the demo. This is so that we can have a more obvious use for the 'Volume Snapshots' feature. You can see it by going to "Admin" button on the top right, or to https://movies-pr-133-cindylopez.demo.okteto.dev/admin/rentals-history