-
Notifications
You must be signed in to change notification settings - Fork 146
Allow per-user tracking for patron XP gains and drystreak tools #6650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TastyPumPum
wants to merge
16
commits into
oldschoolgg:master
Choose a base branch
from
TastyPumPum:user-xp-gains
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the /tools patron xp_gains and /tools patron drystreak commands so they can target a specific account instead of only showing the top 10.
For XP gains, an optional user_id argument is now accepted. When provided, the command sanitises and validates the Discord ID, filters the xp_gains query to that user, and replies with a single-line summary of their XP over the chosen interval (or a friendly “no gains found” message). Leaving user_id blank keeps the existing leaderboard behaviour unchanged.
For drystreaks, an optional user_id argument has been added alongside new helper functions for per-user checks. For monsters and openables, the command now returns a tailored message that:
If no user_id is supplied, the original “top 10 driest players” leaderboard behaviour is preserved.