feat: e2e dataset benchmarks, CI regression job, contributor docs#21
Conversation
- Add Docker-backed dataset E2E bench scripts, compose services, multi-run aggregates - Add baseline compare + template JSON; wire CI job on Postgres - Document benchmark output/regression in docs/benchmark-regression.md - Add CONTRIBUTING, issue template + config; README updates; GIF script UX - Typecheck scripts via tsconfig; exclude scripts from build; Prisma shim types
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis pull request introduces a comprehensive benchmarking infrastructure for the queryd query observability library. The changes include three benchmark script variants (micro, end-to-end, and dataset-focused), supporting Docker Compose configuration, CI automation, new documentation explaining benchmarking methodology, a Prisma type shim, contributor guidelines, and a README reframe describing queryd as a lightweight query observability layer. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 24571840899Coverage remained the same at 95.97%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
🎉 This PR is included in version 1.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
- Add Docker-backed dataset E2E bench scripts, compose services, multi-run aggregates - Add baseline compare + template JSON; wire CI job on Postgres - Document benchmark output/regression in docs/benchmark-regression.md - Add CONTRIBUTING, issue template + config; README updates; GIF script UX - Typecheck scripts via tsconfig; exclude scripts from build; Prisma shim types
Summary
bench/e2e-dataset-baseline.jsontemplate; CI job onci-release.yml(Postgres service) writes latest JSON and runs compare (baselineenforced: falseby default).docs/benchmark-regression.md(how to read aggregates + baselines); README benchmark section updates; CONTRIBUTING + Integration feedback issue template +config.yml(template chooser).tsconfigincludesscripts/**for typecheck;tsconfig.build.jsonexcludes scripts from publish build; Prisma shim types where needed;.gitignorefor generated GIF +bench/latest-e2e-dataset.json.QUERYD_GIF_*env vars).Usage
Run dataset E2E benchmark in Docker:
Multi-run aggregate (example from
package.json):Compare latest JSON to baseline (non-zero exit if enforced ceilings exceeded):
Regenerate README demo GIF (needs
magick+ffmpeg):Contributor checks:
npm ci npm test npm run build npm run typecheckOpen integration feedback (after merge to default branch):
https://github.com/oleg-koval/slow-query-detector/issues/new/choose → Integration feedback
Notes
npm testfailed here with missing@rolldown/binding-darwin-arm64(optional dependency); please rely on CI for green tests.enforced: trueand fillingceilingMedianPerOpUsinbench/e2e-dataset-baseline.jsononce you have stable CI medians (seedocs/benchmark-regression.md).Summary by CodeRabbit
New Features
Documentation
Chores