Skip to content

support marking text which already includes marks #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support marking text which already includes marks #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d39a1e
support marking pinyin where tones may already be marked
dound Nov 13, 2020
9453021
fix github dependency format
dound Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function convert(text, options) {
* @returns {String} Word with marked tone
*/
function mark(word, toneNumber) {
if (toneNumber === 5) {
if (toneNumber === 5 || toneNumber === null) {
return word
}

Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pinyin-tone-convert",
"version": "0.0.2",
"version": "0.1.2",
"description": "Convert Pinyin tone numbers to tone marks.",
"main": "index.js",
"scripts": {
Expand All @@ -23,7 +23,7 @@
},
"homepage": "https://github.com/oleglegun/pinyin-tone-convert#readme",
"dependencies": {
"pinyin-tone-parse": "0.1.1"
"pinyin-tone-parse": "dound/pinyin-tone-parse#a1efb3fb64d117f819086420814b89149fad1cfa"
},
"devDependencies": {
"tap": "^12.0.1"
Expand Down
7 changes: 7 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,15 @@ const testCasesValid = [
text: 'Zhong1guo2ren2 ai4 he1 cha2 hai2shi5 ka1fei1?',
result: 'Zhōngguórén ài hē chá háishi kāfēi?',
},
{
options: { allowAnyChar: true },
text: 'nǐhǎo。 yī，èr，sān！',
result: 'nǐhǎo。 yī，èr，sān！'
}
]

testCasesValid.forEach(test => {
tap.equal(toneConvert(test.text, test.options), test.result)
// tone marks as input just get left as is
tap.equal(toneConvert(toneConvert(test.text, test.options), { allowAnyChar: true }), test.result)
})