Skip to content

fix: Chat message model name is removed on edit #135 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

fix: Chat message model name is removed on edit #135 #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ChatScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export default function ChatScreen({
if (!currConvId) return;
setCurrNodeId(msg.id);
scrollToBottom(true);
await replaceMessage(currConvId, msg, content, onChunk);
await replaceMessage({ msg, newContent: content, onChunk });
scrollToBottom(false, 10);
},
[replaceMessage, scrollToBottom, currConvId, onChunk]
Expand Down
39 changes: 14 additions & 25 deletions src/context/message.context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ interface SendMessageProps {
system?: string;
onChunk: CallbackGeneratedChunk;
}
interface ReplaceMessageProps {
msg: Message;
newContent: string;
onChunk: CallbackGeneratedChunk;
}

interface MessageContextValue {
// canvas
Expand All @@ -38,12 +43,7 @@ interface MessageContextValue {
isGenerating: (convId: string) => boolean;
sendMessage: (props: SendMessageProps) => Promise<boolean>;
stopGenerating: (convId: string) => void;
replaceMessage: (
convId: string,
msg: Message,
content: string | null,
onChunk: CallbackGeneratedChunk
) => Promise<void>;
replaceMessage: (props: ReplaceMessageProps) => Promise<void>;
branchMessage: (msg: Message) => Promise<void>;
}

Expand Down Expand Up @@ -323,32 +323,21 @@ export const MessageContextProvider = ({
aborts[convId]?.abort();
};

const replaceMessage = async (
convId: string,
msg: Message,
content: string | null,
onChunk: CallbackGeneratedChunk
) => {
if (isGenerating(convId)) return;

if (content == null) {
onChunk(msg.parent);
return;
}
const replaceMessage = async ({
msg,
newContent,
onChunk,
}: ReplaceMessageProps) => {
if (isGenerating(msg.convId)) return;

const now = Date.now();
const currMsgId = now;
await StorageUtils.appendMsg(
{
...msg,
id: currMsgId,
convId,
type: msg.type,
role: msg.role,
content,
extra: msg.extra,
parent: msg.parent,
children: [],
timestamp: now,
content: newContent,
},
msg.parent
);
Expand Down