Video playback handling in VideoArkitPlugin #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuslanTsitser
commented
Apr 8, 2025
RuslanTsitser
commented
- Added video payback control
- Added video file support
olexale
reviewed
Aug 25, 2025
| switch call.method { | ||
| case "play": | ||
| VideoArkitPlugin.nodes[id]?.play() | ||
| VideoArkitPlugin.players[id]?.play() |
There was a problem hiding this comment.
Wouldn't that be a breaking change for folks who use SKVideoNode?
|
|
||
| /// Seek video to a specific time. | ||
| Future<void> seekTo(Duration duration) => | ||
| _channel.invokeMethod<void>('seek', {'id': id, 'seconds': duration.inSeconds}); |
There was a problem hiding this comment.
I think using milliseconds would be a better fit, as it gives users finer control over the timing.
| } else if let filePath = dict["filePath"] as? String { | ||
| let videoFileURL = URL(fileURLWithPath: filePath) | ||
| videoPlayer = AVPlayer(url: videoFileURL) | ||
| videoNode = SKVideoNode(avPlayer: videoPlayer!) |
There was a problem hiding this comment.
Please avoid using force unwraps. If videoPlayer creation fails, call logPluginError instead.
| String? filename, | ||
| String? url, | ||
| bool? autoplay = true, | ||
| String? filePath, |
There was a problem hiding this comment.
For users, the distinction between filename and filePath might not be obvious. What benefits do we gain from using SKVideoNode(fileNamed: videoFilename)? Do you think it would be more consistent to always rely on SKVideoNode(avPlayer: videoPlayer) instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.