default range selection initialization can be disabled #4659
+39
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for making a PR! Question - what happens if we press keyboard to navigate while the range does not exist? |
Contributor
Author
when the range does not exist, keyboard presses to navigate do nothing. You first need to select a range before you can navigate by keyboard. |
azmy60
requested changes
Feb 28, 2025
Collaborator
azmy60
left a comment
azmy60
left a comment
There was a problem hiding this comment.
It's a great idea! But there are some changes needed before merge. I would prefer not to pass boolean flags to function like this if we can avoid that.
stefanhoelzl
force-pushed
the
disable-default-range-selection
branch
from
3a26f31 to
bae2f77
Compare
azmy60
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4634
by default cell [0,0] is selected, when range selection is disabled. With this change this can be disabled, so that on table init no range is selected.