Keep D3D enabled for Skia m149 Windows Release#11
Open
danielraffel wants to merge 1 commit into
Open
Conversation
danielraffel
changed the title
danielraffel
force-pushed
the
pr/m149-d3d-release-build
branch
from
2e75b61 to
443fefa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a narrow alternative to the D3D workaround in #7.
When building
chrome/m149, Windows Debug completed but Windows Release failed in Skia's D3D backend source. #7 avoids that by disabling Direct3D for now. This keepsskia_use_direct3d = trueand applies a small source patch through the existing patch mechanism.The failure is in
GrD3DBackendSurface.cpp: theequaloverrides do not line up with theGPU_TEST_UTILSguards used by the base classes on this branch.Tested in a fork against
chrome/m149; the Windows Release job and full release matrix completed. If disabling D3D until Skia fixes this upstream is preferred, this can just be closed.